Skip to content

feat(sqlc): support emit_pointers_for_null_types for enums#3093

Closed
godwhoa wants to merge 1 commit into
sqlc-dev:mainfrom
godwhoa:enum-emit-pointer
Closed

feat(sqlc): support emit_pointers_for_null_types for enums#3093
godwhoa wants to merge 1 commit into
sqlc-dev:mainfrom
godwhoa:enum-emit-pointer

Conversation

@godwhoa

@godwhoa godwhoa commented Jan 2, 2024

Copy link
Copy Markdown

No description provided.

@godwhoa godwhoa marked this pull request as ready for review January 3, 2024 04:26
@andrewmbenton

Copy link
Copy Markdown
Collaborator

I think this might not be enough. Do we not also need to modify the scanning code for the non-nullable enum types so that they properly return a nil pointer when they scan a NULL? Or does this somehow "just work"?

Have you tried manually modifying the sqlc output to use pointers for nullable enums and confirmed that this proposed change alone does actually work as expected?

@godwhoa

godwhoa commented Jan 10, 2024

Copy link
Copy Markdown
Author

@andrewmbenton I did try with a basic INSERT RETURNING locally which worked, but didn't try any more elaborate cases that you mention.
Will try to pick it up over the week. Also, looks like CI isn't working on my PR any clue why?

Copy link
Copy Markdown
Collaborator

🤖 Automated message

This PR has been closed because it has merge conflicts with main. To reopen it, rebase onto the latest main to resolve the conflicts, then reopen the PR.


Generated by Claude Code

@kyleconroy kyleconroy closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants